Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Tags: Architectures Platforms default
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

Architectures Platforms default
Adam D. Moss
Non-l2arc pool reads shouldn't be l2arc misses

The current l2_misses accounting behavior treats all reads to pools
without a configured l2arc as an l2arc miss, IFF there is at least
one other pool on the system which does have an l2arc configured.

This makes it extremely hard to tune for an improved l2arc hit/miss
ratio because this ratio will be modulated by reads from pools which
do not (and should not) have l2arc devices; its upper limit will
depend on the ratio of reads from l2arc'd pools and non-l2arc'd pools.

This PR prevents ARC reads affecting l2arc stats (n.b. l2_misses is
the only relevant one) where the target spa doesn't have an l2arc.

Includes new test - l2arc_l2miss_pos.ksh

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Adam Moss <c@yotes.com>
Closes #10921
Kyle Evans
Makefile.bsd: remove directory that no longer exists

This was removed in a reorganization of directories preparing for the
merge of FreeBSD support, 006e9a408824 by mmacy. While llvm is perfectly
happy with the nonexistent -I directory, the gcc6 and gcc9 we can elect
to use as cross-toolchains both trip over it.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
Closes #11077
Cy Schubert
Remove extraneous garbage.

Pull-request: #11088 part 5/5
Cy Schubert
Fixup indentation.

Pull-request: #11088 part 4/5
Cy Schubert
Fixup indentation.

Pull-request: #11088 part 3/5
Cy Schubert
Restore identification of VDEVs using non-native block size.

NAME        STATE    READ WRITE CKSUM
dsk02        ONLINE      0    0    0
  mirror-0  ONLINE      0    0    0
    ada1s4a  ONLINE      0    0    0
    ada2s4a  ONLINE      0    0    0  block size: 512B configured, 4096B native

Pull-request: #11088 part 2/5
Cy Schubert
Restore identification of VDEVs using non-native block size.

NAME        STATE    READ WRITE CKSUM
dsk02        ONLINE      0    0    0
  mirror-0  ONLINE      0    0    0
    ada1s4a  ONLINE      0    0    0
    ada2s4a  ONLINE      0    0    0  block size: 512B configured, 4096B native

Pull-request: #11088 part 1/5
Cy Schubert
Fixup indentation.

Pull-request: #11088 part 4/4
Cy Schubert
Fixup indentation.

Pull-request: #11088 part 3/4
Cy Schubert
Restore identification of VDEVs using non-native block size.

NAME        STATE    READ WRITE CKSUM
dsk02        ONLINE      0    0    0
  mirror-0  ONLINE      0    0    0
    ada1s4a  ONLINE      0    0    0
    ada2s4a  ONLINE      0    0    0  block size: 512B configured, 4096B native

Pull-request: #11088 part 2/4
Cy Schubert
Restore identification of VDEVs using non-native block size.

NAME        STATE    READ WRITE CKSUM
dsk02        ONLINE      0    0    0
  mirror-0  ONLINE      0    0    0
    ada1s4a  ONLINE      0    0    0
    ada2s4a  ONLINE      0    0    0  block size: 512B configured, 4096B native

Pull-request: #11088 part 1/1
Matthew Macy
FreeBSD: delete unreferenced file

zfs_onexit_os.c was not deleted when it was removed from the build

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes #11079
Ryan Moeller
Fix commitcheck on FreeBSD

Convert from bash to sh, avoid Perl regexes and \s, prune unused
functions.

Reviewed-by: Mateusz Piotrowski <0mp@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org>
Closes #11070
Brian Behlendorf
Tag 2.0.0-rc4

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Don Brady
zed syslog entries drop important info

ZED will log zevents summaries to the syslog, however the log entries
tend to drop event details that can be useful for diagnosis. This is
especially true for ereport events, like io, checksum, and delay.

Update the all-syslog.sh script to log additional event information.

Add an optional config option, ZED_SYSLOG_DISPLAY_GUIDS, to zed.rc
for choosing GUIDs over names for pool and vdev.

Change the default ZED_SYSLOG_SUBCLASS_EXCLUDE to exclude history_event
events. These events tend to be frequent, convey no meaningful info,
and are already logged in the zpool history.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Don Brady <don.brady@delphix.com>
Closes #10967
Don Brady
zed syslog entries drop important info

ZED will log zevents summaries to the syslog, however the log entries
tend to drop event details that can be useful for diagnosis. This is
especially true for ereport events, like io, checksum, and delay.

Update the all-syslog.sh script to log additional event information.

Add an optional config option, ZED_SYSLOG_DISPLAY_GUIDS, to zed.rc
for choosing GUIDs over names for pool and vdev.

Change the default ZED_SYSLOG_SUBCLASS_EXCLUDE to exclude history_event
events. These events tend to be frequent, convey no meaningful info,
and are already logged in the zpool history.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Don Brady <don.brady@delphix.com>
Closes #10967
xtouqh
Properly format NAME subsection of zfs/zpool subcommands

Use proper names (i.e. zfs-allow and zpool-add) in NAME subsections
of zfs/zpool subcommands instead of current "pretty-printed" ones as
makewhatis utilities (or some implementations of it, namely the one
from mandoc suite used in FreeBSD) look not only at the document title
but also in NAME subsection, adding zfs(8)/zpool(8) to search results
which is not correct. (Common sense and other utilities splitting
subcommands in multiple man pages, e.g. git, do the same.)

Signed-off-by: xtouqh@hotmail.com

Pull-request: #11086 part 1/1
Coleman Kane
Fixes to autotools macro for percpu_ref count var

The original version I wrote performed some dereference logic which
worked in my own builds, but appears to not work in the autotools setup
used in the style checker. This commit simplifies the test and hopefully
will appease more variations of autotools.

Signed-off-by: Coleman Kane <ckane@colemankane.org>

Pull-request: #11085 part 6/6
Allan Jude
zfs list: Allow more fields in ZFS_ITER_SIMPLE mode

If the fields to be listed and sorted by are constrained
to those populated by dsl_dataset_fast_stat(), then
zfs list is much faster, as it does not need to open each
objset and reads its properties.

A previous optimization by Pawel Dawidek
(0cee24064a79f9c01fc4521543c37acea538405f) took advantage
of this to make listing snapshot names sorted only by name
much faster.

However, it was limited to `-o name -s name`, this work
extends this optimization to work with:
  - name
  - guid
  - createtxg
  - numclones
  - inconsistent
  - redacted
  - origin
and to work for filesystems as well as snapshots.
This could be further extended to any other properties
supported by dsl_dataset_fast_stat() or similar, that do
not require extra locking or reading from disk.

Additional optimizations could be made by making some
internal processes, like listing snapshots for deletion
use this "fast" mode, since only the name needs to be
looked up, but that is left as future work.

Signed-off-by: Allan Jude <allan@klarasystems.com>

Pull-request: #11080 part 5/5
Allan Jude
Expand iterator APIs

Signed-off-by: Allan Jude <allanjude@freebsd.org>

Pull-request: #11080 part 4/5
Allan Jude
Fix origin handling

Signed-off-by: Allan Jude <allanjude@freebsd.org>

Pull-request: #11080 part 3/5
Allan Jude
Address review feedback

Signed-off-by: Allan Jude <allanjude@freebsd.org>

Pull-request: #11080 part 2/5
Allan Jude
zfs list: Allow more fields in ZFS_ITER_SIMPLE mode

If the fields to be listed and sorted by is constrained
to those populated by dsl_dataset_fast_stat(), then
zfs list is much faster, as it does not need to open each
objset and reads its properties.

A previous optimization by Pawel Dawidek
(0cee24064a79f9c01fc4521543c37acea538405f) took advantage
of this to make listing snapshot names sorted only by name
much faster.

However, it was limited to `-o name -s name`, this work
extends this optimization to work with:
  - name
  - guid
  - createtxg
  - numclones
  - inconsistent
  - redacted
  - origin
and could be further extended to any other properties
supported by dsl_dataset_fast_stat() or similar, that do
not require extra locking or reading from disk.

Signed-off-by: Allan Jude <allan@klarasystems.com>

Pull-request: #11080 part 1/5
Allan Jude
zfs list: Allow more fields in ZFS_ITER_SIMPLE mode

If the fields to be listed and sorted by are constrained
to those populated by dsl_dataset_fast_stat(), then
zfs list is much faster, as it does not need to open each
objset and reads its properties.

A previous optimization by Pawel Dawidek
(0cee24064a79f9c01fc4521543c37acea538405f) took advantage
of this to make listing snapshot names sorted only by name
much faster.

However, it was limited to `-o name -s name`, this work
extends this optimization to work with:
  - name
  - guid
  - createtxg
  - numclones
  - inconsistent
  - redacted
  - origin
and to work for filesystems as well as snapshots.
This could be further extended to any other properties
supported by dsl_dataset_fast_stat() or similar, that do
not require extra locking or reading from disk.

Additional optimizations could be made by making some
internal processes, like listing snapshots for deletion
use this "fast" mode, since only the name needs to be
looked up, but that is left as future work.

Signed-off-by: Allan Jude <allan@klarasystems.com>

Pull-request: #11080 part 5/5
Allan Jude
Expand iterator APIs

Signed-off-by: Allan Jude <allanjude@freebsd.org>

Pull-request: #11080 part 4/5
Allan Jude
Fix origin handling

Signed-off-by: Allan Jude <allanjude@freebsd.org>

Pull-request: #11080 part 3/5
Allan Jude
Address review feedback

Signed-off-by: Allan Jude <allanjude@freebsd.org>

Pull-request: #11080 part 2/5
Allan Jude
zfs list: Allow more fields in ZFS_ITER_SIMPLE mode

If the fields to be listed and sorted by is constrained
to those populated by dsl_dataset_fast_stat(), then
zfs list is much faster, as it does not need to open each
objset and reads its properties.

A previous optimization by Pawel Dawidek
(0cee24064a79f9c01fc4521543c37acea538405f) took advantage
of this to make listing snapshot names sorted only by name
much faster.

However, it was limited to `-o name -s name`, this work
extends this optimization to work with:
  - name
  - guid
  - createtxg
  - numclones
  - inconsistent
  - redacted
  - origin
and could be further extended to any other properties
supported by dsl_dataset_fast_stat() or similar, that do
not require extra locking or reading from disk.

Signed-off-by: Allan Jude <allan@klarasystems.com>

Pull-request: #11080 part 1/5
Matt Macy
Share zfs_fsync, zfs_read, zfs_write, et al between Linux and FreeBSD

Signed-off-by: Matt Macy <mmacy@FreeBSD.org>

Pull-request: #11078 part 1/1
Matt Macy
Share zfs_fsync, zfs_read, zfs_write, et al between Linux and FreeBSD

Signed-off-by: Matt Macy <mmacy@FreeBSD.org>

Pull-request: #11078 part 1/1
Colm Buckley
Catch zero-sized features files.

Signed-off-by: Colm Buckley <colm@tuatha.org>

Pull-request: #10980 part 5/5
Colm Buckley
Prevent 'features' and 'version' from being specified together.

Signed-off-by: Colm Buckley <colm@tuatha.org>

Pull-request: #10980 part 4/5
Colm Buckley
Correct mdoc syntax.

Signed-off-by: Colm Buckley <colm@tuatha.org>

Pull-request: #10980 part 3/5
Colm Buckley
Add 'features' to zpool_get.cfg

Signed-off-by: Colm Buckley <colm@tuatha.org>

Pull-request: #10980 part 2/5
Colm Buckley
Add "features" property for zpool feature sets.

Property to allow sets of features to be specified;
influences the behavior of 'zpool upgrade' and 'zpool create'.
Initial man page changes included.

Brief synopsis:

zpool create -o features=all|none|file[,file...] pool vdev...

features = all : request that all features be enabled
features = none : request that no features be enabled
features = file[,file...] : read features from the specified files.
Only features present in *all* files will be enabled on the resulting
pool.

Only affects zpool create, zpool upgrade and zpool status.

Signed-off-by: Colm Buckley <colm@tuatha.org>

Pull-request: #10980 part 1/5
Don Brady
Address another ZTS edge case

Signed-off-by: Don Brady <don.brady@delphix.com>

Pull-request: #10967 part 4/4
Don Brady
address review feedback

Signed-off-by: Don Brady <don.brady@delphix.com>

Pull-request: #10967 part 3/4
Don Brady
backout use of -d 8 with run_and_verify

Signed-off-by: Don Brady <don.brady@delphix.com>

Pull-request: #10967 part 2/4
Don Brady
zed syslog entries drop important info

Signed-off-by: Don Brady <don.brady@delphix.com>

Pull-request: #10967 part 1/4