Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View


Tags: Architectures Platforms default
Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

Architectures Platforms default
Alexander Motin
ZIL: Allow to replay blocks of any size.

There seems to be no reason for ZIL blocks to be limited by 128KB
other than replay code is written in such a way.  This change does
not increase the limit yet, just removes the artificial limitation.

Avoided extra memcpy() may save us a second during replay.

Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.

Pull-request: #14910 part 1/1
Alexander Motin
ZIL: Allow to replay blocks of any size.

There seems to be no reason for ZIL blocks to be limited by 128KB
other than replay code is written in such a way.  This change does
not increase the limit yet, just removes the artificial limitation.

Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.

Pull-request: #14910 part 1/1
Alexander Motin
ZIL: Allow ZIL to replay blocks of any size.

There seems to be no reason for ZIL blocks to be limited by 128KB
other than replay code is written in such a way.  This change does
not increase the limit yet, just removes the artificial limitation.

Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.

Pull-request: #14910 part 1/1
Alexander Motin
ZIL: Improve next log block size prediction.

Detect single-threaded workloads by checking the previous block is
fully written and flushed.  It allows to make size prediction logic
much more precise and skip commit delays, since we can give up on
write aggregation in that case.

Since single-threaded workloads are no longer delayed, increase
zfs_commit_timeout_pct from 5 to 10%.  Parallel workloads should
less care about it, and it should provide more aggregation.

Remove zil_min_commit_timeout tunable, since very fast ZILs should
detect most of workloads as single-threaded.  And when not, not
delaying writes wastes extra block space allocated for aggregation.

Track history in context of bursts, not individual log blocks.  It
allows to not blow away all the history by single large burst of
many block, and same time allows optimizations covering multiple
blocks in a burst and even predicted following burst.  For each
burst account its optimal block size and minimal first block size.
Use that statistics from the last 8 bursts to predict first block
size of the next burst.

Remove predefined set of block sizes.  Allocate any size we see fit,
multiple of 4KB, as required by ZIL now.  With compression enabled
by default, ZFS already writes pretty random block sizes, so this
should not surprise space allocator any more.

Allow zio_alloc_zil() to allocate bigger blocks if predicted size
does not align well with pool's minimum allocation size.  ZIL can
make a good use of whatever block size it is given.

Reduce max_waste_space from 12 to 6% and max_copied_data from 63KB
to 8KB.  It allows prediction to be more precise on large bursts,
improve space efficiency and reduce extra memory copying.

Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.

Pull-request: #14909 part 1/1
Alexander Motin
ZIL: Improve next log block size prediction.

Detect single-threaded workloads by checking the previous block is
fully written and flushed.  It allows to make size prediction logic
much more precise and skip commit delays, since we can give up on
write aggregation in that case.

Since single-threaded workloads are no longer delayed, increase
zfs_commit_timeout_pct from 5 to 10%.  Parallel workloads should
less care about it, and it should provide more aggregation.

Remove zil_min_commit_timeout tunable, since very fast ZILs should
detect most of workloads as single-threaded.  And when not, not
delaying writes wastes extra block space allocated for aggregation.

Track history in context of bursts, not individual log blocks.  It
allows to not blow away all the history by single large burst of
many block, and same time allows optimizations covering multiple
blocks in a burst and even predicted following burst.  For each
burst account its optimal block size and minimal first block size.
Use that statistics from the last 8 bursts to predict first block
size of the next burst.

Remove predefined set of block sizes.  Allocate any size we see fit,
multiple of 4KB, as required by ZIL now.  With compression enabled
by default, ZFS already writes pretty random block sizes, so this
should not surprise space allocator any more.

Reduce max_waste_space from 12 to 6% and max_copied_data from 63KB
to 8KB.  It allows prediction to be more precise on large bursts,
improve space efficiency and reduce extra memory copying.

Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.

Pull-request: #14909 part 1/1
Alexander Motin
ZIL: Improve next log block size prediction.

Detect single-threaded workloads by checking the previous block is
fully written and flushed.  It allows to make size prediction logic
much more precise and skip commit delays, since we can give up on
write aggregation in that case.

Since single-threaded workloads are no longer delayed, increase
zfs_commit_timeout_pct from 5 to 10%.  Parallel workloads should
less care about it, and it should provide more aggregation.

Remove zil_min_commit_timeout tunable, since very fast ZILs should
detect most of workloads as single-threaded.  And when not, not
delaying writes wastes extra block space allocated for aggregation.

Track history in context of bursts, not individual log blocks.  It
allows to not blow away all the history by single large burst of
many block, and same time allows optimizations covering multiple
blocks in a burst and even predicted following burst.  For each
burst account its optimal block size and minimal first block size.
Use that statistics from the last 8 bursts to predict first block
size of the next burst.

Remove predefined set of block sizes.  Allocate any size we see fit,
multiple of 4KB, as required by ZIL now.  With compression enabled
by default, ZFS already writes pretty random block sizes, so this
should not surprise space allocator any more.

Reduce max_waste_space from 12 to 6% and max_copied_data from 63KB
to 8KB.  It allows prediction to be more precise on large bursts,
improve space efficiency and reduce extra memory copying.

Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.

Pull-request: #14909 part 1/1
Alexander Motin
ZIL: Improve next log block size prediction.

Detect single-threaded workloads by checking the previous block is
fully written and flushed.  It allows to make size prediction logic
much more precise and skip commit delays, since we can give up on
write aggregation in that case.

Since single-threaded workloads are no longer delayed, increase
zfs_commit_timeout_pct from 5 to 10%.  Parallel workloads should
less care about it, and it should provide more aggregation.

Remove zil_min_commit_timeout tunable, since very fast ZILs should
detect most of workloads as single-threaded.  And when not, not
delaying writes wastes extra block space allocated for aggregation.

Track history in context of bursts, not individual log blocks.  It
allows to not blow away all the history by single large burst of
many block, and same time allows optimizations covering multiple
blocks in a burst and even predicted following burst.  For each
burst account its optimal block size and minimal first block size.
Use that statistics from the last 8 bursts to predict first block
size of the next burst.

Remove predefined set of block sizes.  Allocate any size we see fit,
multiple of 4KB, as required by ZIL now.  With compression enabled
by default, ZFS already writes pretty random block sizes, so this
should not surprise space allocator any more.

Reduce max_waste_space from 12 to 6% and max_copied_data from 63KB
to 8KB.  It allows prediction to be more precise on large bursts,
improve space efficiency and reduce extra memory copying.

Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.

Pull-request: #14909 part 1/1
Rich Ercolani
Revert "initramfs: use `mount.zfs` instead of `mount`"

This broke mounting of snapshots on / for users.

See https://github.com/openzfs/zfs/issues/9461#issuecomment-1376162949 for more context.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>

Pull-request: #14908 part 1/1
Brian Behlendorf
ZTS: Add zpool_resilver_concurrent exception

The zpool_resilver_concurrent test case requires the ZED which is not used
on FreeBSD.  Add this test to the known list of skipped tested for FreeBSD.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #14904

Pull-request: #14907 part 1/1
Brian Behlendorf
Fix test-runner on FreeBSD

CLOCK_MONOTONIC_RAW is only a thing on Linux and macOS. I'm not
actually sure why the previous hardcoding of a constant didn't
error out, but when we removed it, it sure does now.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes #12995

Pull-request: #14906 part 7/7
Brian Behlendorf
FreeBSD: add missing vop_fplookup assignments

It became illegal to not have them as of
5f6df177758b9dff88e4b6069aeb2359e8b0c493 ("vfs: validate that vop
vectors provide all or none fplookup vops") upstream.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes #14788

Pull-request: #14906 part 6/6
Brian Behlendorf
Fix checkstyle warning

Resolve a missed checkstyle warning.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #14799

Pull-request: #14906 part 4/4
Brian Behlendorf
FreeBSD: add missing vn state transition for .zfs

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes #14774

Pull-request: #14906 part 3/4
Brian Behlendorf
FreeBSD: fix up EINVAL from getdirentries on .zfs

Without the change:
/.zfs
/.zfs/snapshot
find: /.zfs: Invalid argument

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes #14774

Pull-request: #14906 part 2/4
Brian Behlendorf
FreeBSD: make zfs_vfs_held() definition consistent with declaration

Noticed while attempting to change FreeBSD's boolean_t into an actual
bool: in include/sys/zfs_ioctl_impl.h, zfs_vfs_held() is declared to
return a boolean_t, but in module/os/freebsd/zfs/zfs_ioctl_os.c it is
defined to return an int. Make the definition match the declaration.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Dimitry Andric <dimitry@andric.com>
Closes #14776

Pull-request: #14906 part 1/4
Brian Behlendorf
FreeBSD: add missing vn state transition for .zfs

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes #14774

Pull-request: #14906 part 3/3
Mike Swanson
Add compatibility symlinks for FreeBSD 12.{3,4} and 13.{0,1,2}

Signed-off-by: Mike Swanson <mikeonthecomputer@gmail.com>

Pull-request: #14902 part 1/1
Tony Hutter
TEST ONLY Force blk-mq to be unsettable for sanity

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 3/3
Tony Hutter
Revert "Optionally skip zil_close during zvol_create_minor_impl"

This reverts commit e197bb24f1857c823b44c2175b2318c472d79731.

Pull-request: #14879 part 2/3
Tony Hutter
zvol: Fix zvol_misc crashes when using blk-mq

We have recently been seeing a lot of zvol_misc test failures when
blk-mq was enabled on F38 and Centos 9 (#14872).  The failures look
to be caused by kernel memory corruption.

This fix removes a slightly dubious optimization in
zfs_uiomove_bvec_rq() that saved the iterator contents of a
rq_for_each_segment().  This optimization allowed restoring the "saved
state" from a previous rq_for_each_segment() call on the same uio so
that you wouldn't need to iterate though each bvec on every
zfs_uiomove_bvec_rq() call.  However, if the kernel is manipulating
the requests/bios/bvecs under the covers between zfs_uiomove_bvec_rq()
calls, then it could result in corruption from using the "saved state".

Fixes: #14872
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 1/3
Tony Hutter
TEST ONLY Force blk-mq to be unsettable for sanity

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 3/3
Tony Hutter
Revert "Optionally skip zil_close during zvol_create_minor_impl"

This reverts commit e197bb24f1857c823b44c2175b2318c472d79731.

Pull-request: #14879 part 2/3
Tony Hutter
zvol: Fix zvol_misc crashes when using blk-mq

We have recently been seeing a lot of zvol_misc test failures when
blk-mq was enabled on F38 and Centos 9 (#14872).  The failures look
to be caused by kernel memory corruption.

This fix removes a slightly dubious optimization in
zfs_uiomove_bvec_rq() that saved the iterator contents of a
rq_for_each_segment().  This optimization allowed restoring the "saved
state" from a previous rq_for_each_segment() call on the same uio so
that you wouldn't need to iterate though each bvec on every
zfs_uiomove_bvec_rq() call.  However, if the kernel is manipulating
the requests/bios/bvecs under the covers between zfs_uiomove_bvec_rq()
calls, then it could result in corruption from using the "saved state".

Fixes: #14872
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 1/3
Tony Hutter
TEST ONLY Force blk-mq to be unsettable for sanity

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 3/3
Tony Hutter
Revert "Optionally skip zil_close during zvol_create_minor_impl"

This reverts commit e197bb24f1857c823b44c2175b2318c472d79731.

Pull-request: #14879 part 2/3
Tony Hutter
zvol: Fix zvol_misc crashes when using blk-mq

We have recently been seeing a lot of zvol_misc test failures when
blk-mq was enabled on F38 and Centos 9 (#14872).  The failures look
to be caused by kernel memory corruption.

This fix removes a slightly dubious optimization in
zfs_uiomove_bvec_rq() that saved the iterator contents of a
rq_for_each_segment().  This optimization allowed restoring the "saved
state" from a previous rq_for_each_segment() call on the same uio so
that you wouldn't need to iterate though each bvec on every
zfs_uiomove_bvec_rq() call.  However, if the kernel is manipulating
the requests/bios/bvecs under the covers between zfs_uiomove_bvec_rq()
calls, then it could result in corruption from using the "saved state".

Fixes: #14872
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 1/3
Tony Hutter
TEST ONLY Force blk-mq to be unsettable for sanity

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 3/3
Tony Hutter
Revert "Optionally skip zil_close during zvol_create_minor_impl"

This reverts commit e197bb24f1857c823b44c2175b2318c472d79731.

Pull-request: #14879 part 2/3
Tony Hutter
zvol: Fix zvol_misc crashes when using blk-mq

We have recently been seeing a lot of zvol_misc test failures when
blk-mq was enabled on F38 and Centos 9 (#14872).  The failures look
to be caused by kernel memory corruption.

This fix removes a slightly dubious optimization in
zfs_uiomove_bvec_rq() that saved the iterator contents of a
rq_for_each_segment().  This optimization allowed restoring the "saved
state" from a previous rq_for_each_segment() call on the same uio so
that you wouldn't need to iterate though each bvec on every
zfs_uiomove_bvec_rq() call.  However, if the kernel is manipulating
the requests/bios/bvecs under the covers between zfs_uiomove_bvec_rq()
calls, then it could result in corruption from using the "saved state".

Fixes: #14872
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 1/3
Tony Hutter
TEST ONLY Force blk-mq to be unsettable for sanity

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 3/3
Tony Hutter
Revert "Optionally skip zil_close during zvol_create_minor_impl"

This reverts commit e197bb24f1857c823b44c2175b2318c472d79731.

Pull-request: #14879 part 2/3
Tony Hutter
zvol: Fix zvol_misc crashes when using blk-mq

We have recently been seeing a lot of zvol_misc test failures when
blk-mq was enabled on F38 and Centos 9 (#14872).  The failures look
to be caused by kernel memory corruption.

This fix removes a slightly dubious optimization in
zfs_uiomove_bvec_rq() that saved the iterator contents of a
rq_for_each_segment().  This optimization allowed restoring the "saved
state" from a previous rq_for_each_segment() call on the same uio so
that you wouldn't need to iterate though each bvec on every
zfs_uiomove_bvec_rq() call.  However, if the kernel is manipulating
the requests/bios/bvecs under the covers between zfs_uiomove_bvec_rq()
calls, then it could result in corruption from using the "saved state".

Fixes: #14872
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Requires-builders: fedora38

Pull-request: #14879 part 1/3
Brian Behlendorf
ZTS: zvol_misc_trim disable blk mq

Disable the zvol_misc_fua.ksh and zvol_misc_trim.ksh test cases on impacted
kernels.  This issue is being actively worked in #14872 and as part of that
fix this commit will be reverted.

    VERIFY(zh->zh_claim_txg == 0) failed
    PANIC at zil.c:904:zil_create()

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #14872
Closes #1487

Pull-request: #14870 part 1/1
Brian Behlendorf
ZTS: zvol_misc_trim disable blk mq

Disable the zvol_misc_fua.ksh and zvol_misc_trim.ksh test cases on impacted
kernels.  This issue is being actively worked in #14872 and as part of that
fix this commit will be reverted.

    VERIFY(zh->zh_claim_txg == 0) failed
    PANIC at zil.c:904:zil_create()

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #14872
Closes #1487

Pull-request: #14870 part 1/1
Rich Ercolani
Pack our DDT ZAPs a bit denser.

The DDT is really inefficient on 4k and up vdevs, because it always
allocates 4k blocks, and while compression could save us somewhat
at ashift 9, that stops being true.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>

Pull-request: #14654 part 1/1
Rob Norris
zdb: add -B option to generate backup stream

This is more-or-less like `zfs send`, but specifying the snapshot by its
objset id for situations where it can't be referenced any other way.

Sponsored-By: Klara, Inc.
Signed-off-by: Rob Norris <rob.norris@klarasystems.com>

Pull-request: #14642 part 1/1
Jorgen Lundman
Fix aarch64 assembly for macOS/M1

Give up advocating to use asm_linkage.h to unify assembly work
between the platforms and just pepper the file with #ifdef instead.

Signed-off-by: Jorgen Lundman <lundman@lundman.net>

Pull-request: #12110 part 4/4
Jorgen Lundman
Fix blake3 on macOS/arm64

    BLAKE3_CTX *ctx = blake3_per_cpu_ctx[CPU_SEQID_UNSTABLE];

We have macOS arm64 to call kmem_alloc() as the cpu_number()
changes quite frequently, and would reuse an already active
ctx.

If in future we want to avoid kmem_alloc, we can use the
blake3_per_cpu_ctx[CPU_SEQID_UNSTABLE] but check if it is
busy, and move to the next free slot. Easily implemented with
CAS.

Signed-off-by: Jorgen Lundman <lundman@lundman.net>

Pull-request: #12110 part 3/4
Jorgen Lundman
Upstream: SHA2 reworking and API for iterating

over multiple implementations

The changes in the shared files to enable macOS support to PR

Signed-off-by: Jorgen Lundman <lundman@lundman.net>

Pull-request: #12110 part 2/4
Jorgen Lundman
Upstream: Add macOS support

Add source files to enable macOS support
Change autoconf/Makefiles to compile
Prepare zfs-tests for macOS but changes come later

Signed-off-by: Jorgen Lundman <lundman@lundman.net>

Pull-request: #12110 part 1/4