Console View
|
Tags: Architectures Platforms default |
|
| Architectures | Platforms | default | ||||||||||||||||||||||
|
|
|
|
||||||||||||||||||||||
|
Matthew Ahrens
mahrens@delphix.com |
|
|
|
|||||||||||||||||||||
|
filesystem_limit/snapshot_limit is incorrectly enforced against root The filesystem_limit and snapshot_limit properties limit the number of filesystems or snapshots that can be created below this dataset. According to the manpage, "The limit is not enforced if the user is allowed to change the limit." Two types of users are allowed to change the limit: 1. Those that have been delegated the `filesystem_limit` or `snapshot_limit` permission, e.g. with `zfs allow USER filesystem_limit DATASET`. This works properly. 2. A user with elevated system priviliges (e.g. root). This does not work - the root user will incorrectly get an error when trying to create a snapshot/filesystem, if it exceeds the `_limit` property. The problem is that `priv_policy_ns()` does not work if the `cred_t` is not that of the current process. This happens when `dsl_enforce_ds_ss_limits()` is called in syncing context (as part of a sync task's check func) to determine the permissions of the corresponding user process. This commit fixes the issue by passing the `task_struct` (typedef'ed as a `proc_t`) to syncing context, and then using `has_capability()` to determine if that process is privileged. Note that we still need to pass the `cred_t` to syncing context so that we can check if the user was delegated this permission with `zfs allow`. This problem only impacts Linux. Wrappers are added to FreeBSD but it continues to use `priv_check_cred()`, which works on arbitrary `cred_t`. Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Closes: #8226 Pull-request: #10545 part 2/2 |
||||||||||||||||||||||||
|
Matthew Ahrens
mahrens@delphix.com |
|
|
|
|||||||||||||||||||||
|
remove unused argument Pull-request: #10545 part 1/2 |
||||||||||||||||||||||||
|
George Amanakis
gamanakis@gmail.com |
|
|
|
|||||||||||||||||||||
|
Fix a persistent L2ARC bug in l2arc_write_done() In case l2arc_write_done() handles a zio that was not successful check that the list of log block pointers is not empty when restoring them in the device header. Otherwise zero them out. In any case perform the actual write updating the device header after the zio of l2arc_write_buffers() completes as l2arc_write_done() may have touched the memory holding the log block pointers in the device header. Signed-off-by: George Amanakis <gamanakis@gmail.com> Pull-request: #10543 part 1/1 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
George Amanakis
gamanakis@gmail.com |
|
|
|
|||||||||||||||||||||
|
Fix a persistent L2ARC bug in l2arc_write_done() In case l2arc_write_done() handles a zio that was not successful check that the list of log block pointers is not empty when restoring them in the device header. Otherwise zero them out. In any case perform the actual write updating the device header after the zio of l2arc_write_buffers() completes as l2arc_write_done() may have touched the memory holding the log block pointers in the device header. Signed-off-by: George Amanakis <gamanakis@gmail.com> Pull-request: #10543 part 1/1 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
Matt Macy
mmacy@mattmacy.io |
|
|
|
|||||||||||||||||||||
|
Make zfs commands backward compatible with zfs in base Signed-off-by: Matt Macy <mmacy@FreeBSD.org> Pull-request: #10542 part 1/1 |
||||||||||||||||||||||||
|
Matt Macy
mmacy@mattmacy.io |
|
|
|
|||||||||||||||||||||
|
Make zfs commands backward compatible with zfs in base Signed-off-by: Matt Macy <mmacy@FreeBSD.org> Pull-request: #10542 part 1/1 |
||||||||||||||||||||||||
|
Ryan Moeller
ryan@iXsystems.com |
|
|
|
|||||||||||||||||||||
|
libzfs: Make zfs_cmd_t initialization consistent, use zfs_ioctl The clang version 8.0.1 shipped in FreeBSD 12.1-RELEASE also oddly throws a warning that is treated as an error on the initialization of the zc struct in zpool_nextboot. The zpool_nextboot code from FreeBSD was not updated to use zfs_ioctl. Switch ioctl to zfs_ioctl in and use {"\0"} to initialize the struct. Do a consistency pass for zfs_cmd_t initialization. Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Pull-request: #10539 part 1/1 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
Ryan Moeller
ryan@iXsystems.com |
|
|
|
|||||||||||||||||||||
|
libzfs: Use zfs_ioctl and different initializer in zpool_nextboot The zpool_nextboot code from FreeBSD was not updated to use zfs_ioctl. The clang version 8.0.1 shipped in FreeBSD 12.1-RELEASE also oddly throws a warning that is treated as an error on the initialization of the zc struct in this function. Switch ioctl to zfs_ioctl and use {"\0"} to initialize the struct. Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Pull-request: #10539 part 1/1 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Use abs_top_builddir when referencing libraries libtool stores absolute paths in the dependency_libs component of the .la files. If the Makefile for a dependent library refers to the libraries by relative path, some libraries end up duplicated on the link command line. As an example, libzfs specifies libzfs_core, libnvpair and libuutil as dependencies to be linked in. The .la file for libzfs_core also specifies libnvpair, but using an absolute path, with the result that libnvpair is present twice in the linker command line for producing libzfs. While the only thing this causes is to slightly slow down the linking, we can avoid it by using absolute paths everywhere, including for convenience libraries just for consistency. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 5/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Add -z defs to LDFLAGS This will make sure the installed libraries are linked with everything they require. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 4/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Add config.rpath for AM_GNU_GETTEXT Commit e8864b1b28c2 ("config: libintl/libiconv for gettext() detection") added an empty config.rpath with a comment that the real one doesn't work with libtool. However, an empty config.rpath doesn't really work: eg. on FreeBSD, where libintl is in /usr/local/lib, configure thinks that gettext doesn't exist and NLS should be disabled, which currently isn't supported in the source, and hence requires manual workaround to directly link -lintl without relying on configure. config.rpath is essential to let it be detected either in --prefix or using --with-libintl-prefix. I also don't see the mentioned issue with libtool flags applied to compilation, it seems to work fine to pass LTLIBINTL to libtool. It's unnecessary to include LTLIBICONV as the configure test will automatically append that to LTLIBINTL if it is necessary to link with libiconv. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 3/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Clean up lib dependencies libzutil is currently statically linked into libzfs, libzfs_core and libzpool. Avoid the unnecessary duplication by removing it from libzfs and libzpool, and adding libzfs_core to libzpool. Remove a few unnecessary dependencies: - libuutil from libzfs_core - libtirpc from libspl - keep only libcrypto in libzfs, as we don't use any functions from libssl - librt is only used for clock_gettime, however on modern systems that's in libc rather than librt. Add a configure check to see if we actually need librt - libdl from raidz_test Add a few missing dependencies: - zlib to libefi and libzfs - libuuid to zpool, and libuuid and libudev to zed - libnvpair uses assertions, so add assert.c to provide aok and libspl_assertf Sort the LDADD for programs so that libraries that satisfy dependencies come at the end rather than the beginning of the linker command line. Revamp the configure tests for libaries to use FIND_SYSTEM_LIBRARY instead. This can take advantage of pkg-config, and it also avoids polluting LIBS. List all the required dependencies in the pkgconfig files, and move the one for libzfs_core into the latter's directory. Install pkgconfig files in $(libdir)/pkgconfig on linux and $(prefix)/libdata/pkgconfig on FreeBSD, instead of /usr/share/pkgconfig, as the more correct location for library .pc files. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 2/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Move libspl_assertf into .c file Variadic functions cannot be inlined. libspl_assertf ends up being duplicated in every file that uses it. Fix this by moving the function into a new assert.c. Also move the definition of aok into the new file instead of zone.c. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 1/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Use abs_top_builddir when referencing libraries libtool stores absolute paths in the dependency_libs component of the .la files. If the Makefile for a dependent library refers to the libraries by relative path, some libraries end up duplicated on the link command line. As an example, libzfs specifies libzfs_core, libnvpair and libuutil as dependencies to be linked in. The .la file for libzfs_core also specifies libnvpair, but using an absolute path, with the result that libnvpair is present twice in the linker command line for producing libzfs. While the only thing this causes is to slightly slow down the linking, we can avoid it by using absolute paths everywhere, including for convenience libraries just for consistency. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 5/5 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Add -z defs to LDFLAGS This will make sure the installed libraries are linked with everything they require. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 4/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Add config.rpath for AM_GNU_GETTEXT Commit e8864b1b28c2 ("config: libintl/libiconv for gettext() detection") added an empty config.rpath with a comment that the real one doesn't work with libtool. However, an empty config.rpath doesn't really work: eg. on FreeBSD, where libintl is in /usr/local/lib, configure thinks that gettext doesn't exist and NLS should be disabled, which currently isn't supported in the source, and hence requires manual workaround to directly link -lintl without relying on configure. config.rpath is essential to let it be detected either in --prefix or using --with-libintl-prefix. I also don't see the mentioned issue with libtool flags applied to compilation, it seems to work fine to pass LTLIBINTL to libtool. It's unnecessary to include LTLIBICONV as the configure test will automatically append that to LTLIBINTL if it is necessary to link with libiconv. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 3/5 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Clean up lib dependencies libzutil is currently statically linked into libzfs, libzfs_core and libzpool. Avoid the unnecessary duplication by removing it from libzfs and libzpool, and adding libzfs_core to libzpool. Remove a few unnecessary dependencies: - libuutil from libzfs_core - libtirpc from libspl - keep only libcrypto in libzfs, as we don't use any functions from libssl - librt is only used for clock_gettime, however on modern systems that's in libc rather than librt. Add a configure check to see if we actually need librt Add a few missing dependencies: - zlib to libefi and libzfs - libnvpair uses assertions, so add assert.c to provide aok and libspl_assertf Sort the LDADD for programs so that libraries that satisfy dependencies come at the end rather than the beginning of the linker command line. Revamp the configure tests for libaries to use FIND_SYSTEM_LIBRARY instead. This can take advantage of pkg-config, and it also avoids polluting LIBS. List all the required dependencies in the pkgconfig files, and move the one for libzfs_core into the latter's directory. Install pkgconfig files in $(libdir)/pkgconfig on linux and $(prefix)/libdata/pkgconfig on FreeBSD, instead of /usr/share/pkgconfig, as the more correct location for library .pc files. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 2/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Move libspl_assertf into .c file Variadic functions cannot be inlined. libspl_assertf ends up being duplicated in every file that uses it. Fix this by moving the function into a new assert.c. Also move the definition of aok into the new file instead of zone.c. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 1/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Use abs_top_builddir when referencing libraries libtool stores absolute paths in the dependency_libs component of the .la files. If the Makefile for a dependent library refers to the libraries by relative path, some libraries end up duplicated on the link command line. As an example, libzfs specifies libzfs_core, libnvpair and libuutil as dependencies to be linked in. The .la file for libzfs_core also specifies libnvpair, but using an absolute path, with the result that libnvpair is present twice in the linker command line for producing libzfs. While the only thing this causes is to slightly slow down the linking, we can avoid it by using absolute paths everywhere, including for convenience libraries just for consistency. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 5/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Add -z defs to LDFLAGS This will make sure the installed libraries are linked with everything they require. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 4/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Add config.rpath for AM_GNU_GETTEXT Commit e8864b1b28c2 ("config: libintl/libiconv for gettext() detection") added an empty config.rpath with a comment that the real one doesn't work with libtool. However, an empty config.rpath doesn't really work: eg. on FreeBSD, where libintl is in /usr/local/lib, configure thinks that gettext doesn't exist and NLS should be disabled, which currently isn't supported in the source, and hence requires manual workaround to directly link -lintl without relying on configure. config.rpath is essential to let it be detected either in --prefix or using --with-libintl-prefix. I also don't see the mentioned issue with libtool flags applied to compilation, it seems to work fine to pass LTLIBINTL to libtool. It's unnecessary to include LTLIBICONV as the configure test will automatically append that to LTLIBINTL if it is necessary to link with libiconv. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 3/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Clean up lib dependencies libzutil is currently statically linked into libzfs, libzfs_core and libzpool. Avoid the unnecessary duplication by removing it from libzfs and libzpool, and adding libzfs_core to libzpool. Remove a few unnecessary dependencies: - libuutil from libzfs_core - libtirpc from libspl - keep only libcrypto in libzfs, as we don't use any functions from libssl - librt is only used for clock_gettime, however on modern systems that's in libc rather than librt. Add a configure check to see if we actually need librt Add a few missing dependencies: - zlib to libefi and libzfs - libnvpair uses assertions, so add assert.c to provide aok and libspl_assertf Sort the LDADD for programs so that libraries that satisfy dependencies come at the end rather than the beginning of the linker command line. Revamp the configure tests for libaries to use FIND_SYSTEM_LIBRARY instead. This can take advantage of pkg-config, and it also avoids polluting LIBS. List all the required dependencies in the pkgconfig files, and move the one for libzfs_core into the latter's directory. Install pkgconfig files in $(libdir)/pkgconfig on linux and $(prefix)/libdata/pkgconfig on FreeBSD, instead of /usr/share/pkgconfig, as the more correct location for library .pc files. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 2/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Move libspl_assertf into .c file Variadic functions cannot be inlined. libspl_assertf ends up being duplicated in every file that uses it. Fix this by moving the function into a new assert.c. Also move the definition of aok into the new file instead of zone.c. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 1/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Use abs_top_builddir when referencing libraries libtool stores absolute paths in the dependency_libs component of the .la files. If the Makefile for a dependent library refers to the libraries by relative path, some libraries end up duplicated on the link command line. As an example, libzfs specifies libzfs_core, libnvpair and libuutil as dependencies to be linked in. The .la file for libzfs_core also specifies libnvpair, but using an absolute path, with the result that libnvpair is present twice in the linker command line for producing libzfs. While the only thing this causes is to slightly slow down the linking, we can avoid it by using absolute paths everywhere. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 5/5 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Add -z defs to LDFLAGS This will make sure the installed libraries are linked with everything they require. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 4/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Add config.rpath for AM_GNU_GETTEXT Commit e8864b1b28c2 ("config: libintl/libiconv for gettext() detection") added an empty config.rpath with a comment that the real one doesn't work with libtool. However, an empty config.rpath doesn't really work: eg. on FreeBSD, where libintl is in /usr/local/lib, configure thinks that gettext doesn't exist and NLS should be disabled, which currently isn't supported in the source, and hence requires manual workaround to directly link -lintl without relying on configure. config.rpath is essential to let it be detected either in --prefix or using --with-libintl-prefix. I also don't see the mentioned issue with libtool flags applied to compilation, it seems to work fine to pass LTLIBINTL to libtool. It's unnecessary to include LTLIBICONV as the configure test will automatically append that to LTLIBINTL if it is necessary to link with libiconv. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 3/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Move libspl_assertf into .c file Variadic functions cannot be inlined. libspl_assertf ends up being duplicated in every file that uses it. Fix this by moving the function into a new assert.c. Also move the definition of aok into the new file instead of zone.c. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 2/5 |
||||||||||||||||||||||||
|
Arvind Sankar
nivedita@alum.mit.edu |
|
|
|
|||||||||||||||||||||
|
Clean up lib dependencies libzutil is currently statically linked into libzfs, libzfs_core and libzpool. Avoid the unnecessary duplication by removing it from libzfs and libzpool, and adding libzfs_core to libzpool. Remove a few unnecessary dependencies: - libuutil from libzfs_core - libtirpc from libspl - keep only libcrypto in libzfs, as we don't use any functions from libssl - librt is only used for clock_gettime, however on modern systems that's in libc rather than librt. Add a configure check to see if we actually need librt Add a few missing dependencies: - zlib to libefi and libzfs - libnvpair uses assertions, so add assert.c to provide aok and libspl_assertf Sort the LDADD for programs so that libraries that satisfy dependencies come at the end rather than the beginning of the linker command line. Revamp the configure tests for libaries to use FIND_SYSTEM_LIBRARY instead. This can take advantage of pkg-config, and it also avoids polluting LIBS. List all the required dependencies in the pkgconfig files, and move the one for libzfs_core into the latter's directory. Install pkgconfig files in $(libdir)/pkgconfig on linux and $(prefix)/libdata/pkgconfig on FreeBSD, instead of /usr/share/pkgconfig, as the more correct location for library .pc files. Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Pull-request: #10538 part 1/5 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
Ryan Moeller
ryan@iXsystems.com |
|
|
|
|||||||||||||||||||||
|
Add zpool_nextboot, move zfs_jail to libzfs.h FreeBSD has a zfsbootcfg command that wants zpool_nextboot in libzfs. Add the function to FreeBSD's libzfs_compat.c, and while here move the prototype for zfs_jail out of param.h in FreeBSD's SPL and into libzfs.h under an ifdef for FreeBSD, where the prototype for zpool_nextboot joins it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #10524 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
Mark Johnston
markj@freebsd.org |
|
|
|
|||||||||||||||||||||
|
Fix a deadlock in the FreeBSD getpages VOP FreeBSD has a per-page "busy" lock which is held when handling a page fault on a mapped file. This lock is also acquired when copying data from the DMU to the page cache in zfs_write(). File range locks are also acquired in both of these paths, in the opposite order with respect to the busy lock. In the getpages VOP, the range lock is only used to determine the extent of optional read-ahead and read-behind operations. To resolve the lock order reversal, modify the getpages VOP to avoid blocking on the range lock. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Signed-off-by: Mark Johnston <markj@FreeBSD.org> Closes #10519 |
||||||||||||||||||||||||
|
Matthew Ahrens
mahrens@delphix.com |
|
|
|
|||||||||||||||||||||
|
Extend zdb to print inconsistencies in livelists and metaslabs Livelists and spacemaps are data structures that are logs of allocations and frees. Livelists entries are block pointers (blkptr_t). Spacemaps entries are ranges of numbers, most often used as to track allocated/freed regions of metaslabs/vdevs. These data structures can become self-inconsistent, for example if a block or range can be "double allocated" (two allocation records without an intervening free) or "double freed" (two free records without an intervening allocation). ZDB (as well as zfs running in the kernel) can detect these inconsistencies when loading livelists and metaslab. However, it generally halts processing when the error is detected. When analyzing an on-disk problem, we often want to know the entire set of inconsistencies, which is not possible with the current behavior. This commit adds a new flag, `zdb -y`, which analyzes the livelist and metaslab data structures and displays all of their inconsistencies. Note that this is different from the leak detection performed by `zdb -b`, which checks for inconsistencies between the spacemaps and the tree of block pointers, but assumes the spacemaps are self-consistent. The specific checks added are: Verify livelists by iterating through each sublivelists and: - report leftover FREEs - report double ALLOCs and double FREEs - record leftover ALLOCs together with their TXG [see Cross Check] Verify spacemaps by iterating over each metaslab and: - iterate over spacemap and then the metaslab's entries in the spacemap log, then report any double FREEs and double ALLOCs Verify that livelists are consistenet with spacemaps. The space referenced by livelists (after using the FREE's to cancel out corresponding ALLOCs) should be allocated, according to the spacemaps. External-issue: DLPX-66031 Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Pull-request: #10515 part 1/1 |
||||||||||||||||||||||||
|
Brian Atkinson
batkinson@lanl.gov |
|
|
|
|||||||||||||||||||||
|
Fixing gang ABD child removal race condition On linux the list debug code has been setting off a failure when checking that the node->next->prev value is pointing back at the node. At times this check evaluates to 0xdead. When removing a child from a gang ABD we must acquire the child's abd_mtx to make sure that the same ABD is not being added to another gang ABD while it is being removed from a gang ABD. This fixes a race condition when checking if an ABDs link is already active and part of another gang ABD before adding it to a gang. Added additional debug code for the gang ABD in abd_verify() to make sure each child ABD has active links. Also check to make sure another gang ABD is not added to a gang ABD. Signed-off-by: Brian Atkinson <batkinson@lanl.gov> Pull-request: #10511 part 1/1 |
||||||||||||||||||||||||
|
Brian Atkinson
batkinson@lanl.gov |
|
|
|
|||||||||||||||||||||
|
Fixing gang ABD child removal race condition On linux the list debug code has been setting off a failure when checking that the node->next->prev value is pointing back at the node. At times this check evaluates to 0xdead. When removing a child from a gang ABD we must acquire the child's abd_mtx to make sure that the same ABD is not being added to another gang ABD while it is being removed from a gang ABD. This fixes a race condition when checking if an ABDs link is already active and part of another gang ABD before adding it to a gang. Also added additional debug code for the gang ABD. Created a call list_link_not_active() to avoid a logic short circuit on the && so both prev and next are checked to see if they are pointing at LIST_POISON values when free'ing the ABD struct. Also added check in abd_verify() to make sure that ABD has active links when it is part of a gang ABD. Signed-off-by: Brian Atkinson <batkinson@lanl.gov> Pull-request: #10511 part 1/1 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
Brian Atkinson
batkinson@lanl.gov |
|
|
|
|||||||||||||||||||||
|
Fixing gang ABD child removal race condition On linux the list debug code has been setting off a failure when checking that the node->next->prev value is pointing back at the node. At times this check evaluates to 0xdead. When removing a child from a gang ABD we must acquire the child's abd_mtx to make sure that the same ABD is not being added to another gang ABD while it is being removed from a gang ABD. This fixes a race condition when checking if an ABDs link is already active and part of another gang ABD before adding it to a gang. Also added additional debug code for the gang ABD. Created a call list_link_not_active() to avoid a logic short circuit on the && so both prev and next are checked to see if they are pointing at LIST_POISON values when free'ing the ABD struct. Also added check in abd_verify() to make sure that ABD has active links when it is part of a gang ABD. Signed-off-by: Brian Atkinson <batkinson@lanl.gov> Foo Pull-request: #10511 part 1/1 |
||||||||||||||||||||||||
|
George Wilson
george.wilson@delphix.com |
|
|
|
|||||||||||||||||||||
|
PR feedback Pull-request: #10300 part 2/2 |
||||||||||||||||||||||||
|
George Wilson
george.wilson@delphix.com |
|
|
|
|||||||||||||||||||||
|
Remove dependency on sharetab file and refactor sharing logic == Motivation and Context The current implementation of 'sharenfs' and 'sharesmb' relies on the use of the sharetab file. The use of this file is os-specific and not required by linux or freebsd. Currently the code must maintain updates to this file which adds complexity and presents a significant performance impact when sharing many datasets. In addition, concurrently running 'zfs sharenfs' command results in missing entries in the sharetab file leading to unexpected failures. == Description This change removes the sharetab logic from the linux and freebsd implementation of 'sharenfs' and 'sharesmb'. It still preserves an os-specific library which contains the logic required for sharing NFS or SMB. The following entry points exist in the vastly simplified libshare library: - sa_enable_share -- shares a dataset but may not commit the change - sa_disable_share -- unshares a dataset but may not commit the change - sa_is_shared -- determine if a dataset is shared - sa_commit_share -- notify NFS/SMB subsystem to commit the shares - sa_validate_shareopts -- determine if sharing options are valid The sa_commit_share entry point is provided as a performance enhancement and is not required. The sa_enable_share/sa_disable_share may commit the share as part of the implementation. Libshare provides a framework for both NFS and SMB but some operating systems may not fully support these protocols or all features of the protocol. NFS Operation: For linux, libshare updates /etc/exports.d/zfs.exports to add and remove shares and then commits the changes by invoking 'exportfs -r'. This file, is automatically read by the kernel NFS implementation which makes for better integration with the NFS systemd service. For FreeBSD, libshare updates /etc/zfs/exports to add and remove shares and then commits the changes by sending a SIGHUP to mountd. SMB Operation: For linux, libshare adds and removes files in /var/lib/samba/usershares by calling the 'net' command directly. There is no need to commit the changes. FreeBSD does not support SMB. == Performance Results To test sharing performance we created a pool with an increasing number of datasets and invoked various zfs actions that would enable and disable sharing. The performance testing was limited to NFS sharing. The following tests were performed on an 8 vCPU system with 128GB and a pool comprised of 4 50GB SSDs: Scale testing: - Share all filesystems in parallel -- zfs sharenfs=on <dataset> & - Unshare all filesystems in parallel -- zfs sharenfs=off <dataset> & Functional testing: - share each filesystem serially -- zfs share -a - unshare each filesystem serially -- zfs unshare -a - reset sharenfs property and unshare -- zfs inherit -r sharenfs <pool> For 'zfs sharenfs=on' scale testing we saw an average reduction in time of 89.43% and for 'zfs sharenfs=off' we saw an average reduction in time of 83.36%. Functional testing also shows a huge improvement: - zfs share -- 97.97% reduction in time - zfs unshare -- 96.47% reduction in time - zfs inhert -r sharenfs -- 99.01% reduction in time Signed-off-by: George Wilson <gwilson@delphix.com> External-Issue: DLPX-68690 Pull-request: #10300 part 1/2 |
||||||||||||||||||||||||
|
GitHub
noreply@github.com |
|
|
|
|||||||||||||||||||||
|
Merge pull request #13 from allanjude/openzfs_zstd_allan Restore previous output format for zdb Pull-request: #10278 part 18/18 |
||||||||||||||||||||||||
|
GitHub
noreply@github.com |
|
|
|
|||||||||||||||||||||
|
Merge pull request #12 from allanjude/openzfs_zstd_allan Replace the compress_level property by merging it into the compress property Pull-request: #10278 part 16/16 |
||||||||||||||||||||||||
|
||||||||||||||||||||||||
|
Michael Niewöhner
foss@mniewoehner.de |
|
|
|
|||||||||||||||||||||
|
[TOBESQUASHED] make zstd code BSD-3-Clause licensed Signed-off-by: Michael Niewöhner <foss@mniewoehner.de> Pull-request: #10278 part 13/13 |
||||||||||||||||||||||||
|
Sebastian Gottschall
s.gottschall@dd-wrt.com |
|
|
|
|||||||||||||||||||||
|
fix style Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com> Pull-request: #10277 part 13/13 |
||||||||||||||||||||||||